Skip to content

Add force-execute input in official workflow#5032

Merged
cbeauchesne merged 2 commits intomainfrom
cbeauchesne/force-execute-wf
Aug 6, 2025
Merged

Add force-execute input in official workflow#5032
cbeauchesne merged 2 commits intomainfrom
cbeauchesne/force-execute-wf

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review August 6, 2025 15:13
@cbeauchesne cbeauchesne requested a review from a team as a code owner August 6, 2025 15:13
Copy link
Copy Markdown
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have documentation for forcing system tests written in https://github.com/DataDog/dd-trace-rb/blob/master/docs/ForcingSystemTests.md, I would think it should be transfered/amended as necessary to this PR.

@cbeauchesne cbeauchesne merged commit 773ad4b into main Aug 6, 2025
1853 of 1915 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/force-execute-wf branch August 6, 2025 16:35
@cbeauchesne
Copy link
Copy Markdown
Collaborator Author

This documentation is about how the list is stored in dd-trace-rb, but not about the parameter itself, so it must kept in dd-trace-rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants