Skip to content

Using prebuilt wheel for dd-trace-py#5146

Merged
cbeauchesne merged 5 commits intomainfrom
nccatoni/use-prebuilt-wheels
Aug 28, 2025
Merged

Using prebuilt wheel for dd-trace-py#5146
cbeauchesne merged 5 commits intomainfrom
nccatoni/use-prebuilt-wheels

Conversation

@nccatoni
Copy link
Copy Markdown
Collaborator

@nccatoni nccatoni commented Aug 27, 2025

Motivation

In the current dev pipeline, the Python tracer is compiled from source. This requires adding build dependencies to the image and waiting for the compilation step on every run, which increases complexity and slows down the workflow.

By switching to a prebuilt wheel, we eliminate these issues:

  • No need to install build dependencies in the image.
  • Faster builds.

Changes

Updated load-binary.sh to fetch a prebuilt wheel from the dd-trace-py CI workflow.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@nccatoni nccatoni changed the title Using wheel for dd-trace-py [python] Using wheel for dd-trace-py Aug 27, 2025
@nccatoni nccatoni changed the title [python] Using wheel for dd-trace-py [python] Using prebuilt wheel for dd-trace-py Aug 27, 2025
@nccatoni nccatoni marked this pull request as ready for review August 27, 2025 09:45
@nccatoni nccatoni requested a review from a team as a code owner August 27, 2025 09:45
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev run is not seing the whl file : https://github.com/DataDog/system-tests/actions/runs/17261437588/job/48983712055?pr=5146#step:8:113

I guess the whl is not saved in the artifact :

Image

Comment thread utils/scripts/load-binary.sh
@nccatoni nccatoni changed the title [python] Using prebuilt wheel for dd-trace-py Using prebuilt wheel for dd-trace-py Aug 27, 2025
@nccatoni nccatoni marked this pull request as draft August 27, 2025 11:53
@nccatoni nccatoni force-pushed the nccatoni/use-prebuilt-wheels branch 13 times, most recently from 6bb814e to 26d3f07 Compare August 28, 2025 07:38
@nccatoni nccatoni force-pushed the nccatoni/use-prebuilt-wheels branch from 26d3f07 to 6ecfdad Compare August 28, 2025 08:02
@nccatoni nccatoni marked this pull request as ready for review August 28, 2025 08:43
@nccatoni nccatoni requested review from a team as code owners August 28, 2025 08:43
@nccatoni nccatoni removed the request for review from a team August 28, 2025 08:43
@nccatoni nccatoni enabled auto-merge (squash) August 28, 2025 12:15
@cbeauchesne cbeauchesne disabled auto-merge August 28, 2025 13:27
@cbeauchesne cbeauchesne merged commit 9ed6ccf into main Aug 28, 2025
1441 of 1557 checks passed
@cbeauchesne cbeauchesne deleted the nccatoni/use-prebuilt-wheels branch August 28, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants