Skip to content

[ruby] enable process tags tests#5886

Closed
wantsui wants to merge 4 commits into
mainfrom
add-ruby-process-tags-test
Closed

[ruby] enable process tags tests#5886
wantsui wants to merge 4 commits into
mainfrom
add-ruby-process-tags-test

Conversation

@wantsui
Copy link
Copy Markdown
Contributor

@wantsui wantsui commented Dec 16, 2025

Motivation

The goal of this PR is to activate the existing process tags in system-tests for Ruby since the following three PRs have been merged:

I'm following the same approach as this .NET PR: #5771

Addresses AIDM-273

Changes

Activates Ruby for the process tags test.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

edit: closed for #6138

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 16, 2025

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/apm_tracing_e2e/test_process_tags.py                              @DataDog/system-tests-core

@wantsui wantsui requested review from marcotc and vandonr December 16, 2025 20:52
@wantsui wantsui marked this pull request as ready for review December 19, 2025 23:27
@wantsui wantsui requested review from a team as code owners December 19, 2025 23:27
@wantsui wantsui closed this Jan 28, 2026
@wantsui wantsui deleted the add-ruby-process-tags-test branch January 28, 2026 21:07
@wantsui
Copy link
Copy Markdown
Contributor Author

wantsui commented Jan 28, 2026

closing in favor of #6138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants