allows list of weblogs in weblog declaration keys#5919
Merged
christophe-papazian merged 11 commits intomainfrom Dec 30, 2025
Merged
allows list of weblogs in weblog declaration keys#5919christophe-papazian merged 11 commits intomainfrom
christophe-papazian merged 11 commits intomainfrom
Conversation
Contributor
|
|
nccatoni
reviewed
Dec 30, 2025
Collaborator
nccatoni
left a comment
There was a problem hiding this comment.
You should use yaml aliases like the refs section. Please consider adding tests in the test the tests scenario
nccatoni
approved these changes
Dec 30, 2025
florentinl
approved these changes
Dec 30, 2025
cbeauchesne
reviewed
Dec 30, 2025
| new_entries: list[Condition] = [] | ||
| all_weblogs: list[str] = [] | ||
| for weblog in e[n]: | ||
| if not isinstance(weblog, str): |
Collaborator
There was a problem hiding this comment.
Is there any valid reason for weblog not being a str ? If no, could you raise a TypeError?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
weblog groups are cool and useful for python tracer to have a more readable manifest.
Changes
Allow weblog groups in manifests:
weblog group aliases should be usable whenever a normal weblog name can be used in the manifest.
Problem
To avoid problematic parsing and difficult json validation, only strings are manipulated at yaml level. The groups are then handled at the python level when parsing.
APPSEC-60404
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present