[python,nodejs] add llm observability parametric initial test#5957
Merged
[python,nodejs] add llm observability parametric initial test#5957
Conversation
Contributor
|
|
Contributor
Author
|
note for reviewers: only adding one test for now since this PR also introduces a DSL for making LLM Observability traces. I will add more tests in a subsequent PR |
cbeauchesne
reviewed
Jan 13, 2026
cbeauchesne
previously requested changes
Jan 13, 2026
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
Just a small RC on a comment, then AGTM
cbeauchesne
approved these changes
Jan 13, 2026
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
AGTM, but could you get a review from someone familiar with the tested feature ?
Kyle-Verhoog
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Consistency testing for LLM Observability SDK functions and behaviors.
MLOB-5162
Changes
Adds new parametric test (initial test, to keep scope small, will add more in a subsequent PR) for LLM Observability.
There is one (a bit larger) change which, while it doesn't affect other parametric tests or client implementations for interacting with the tracers, does introduce something non-standard.
I'm totally down to change the naming of these test request structures, but I felt it important to try and retain them in migrating over to system tests. I know it breaks the pattern a bit, but I'm wondering since it doesn't encroach on existing tests and is fairly well-separated if it's OK to include 😄
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present