Skip to content

[envoy / haproxy] Create new components manifests#6024

Merged
e-n-0 merged 26 commits intomainfrom
flavien/proxies/go-proxies-manifest
Jan 27, 2026
Merged

[envoy / haproxy] Create new components manifests#6024
e-n-0 merged 26 commits intomainfrom
flavien/proxies/go-proxies-manifest

Conversation

@e-n-0
Copy link
Copy Markdown
Member

@e-n-0 e-n-0 commented Jan 14, 2026

Motivation

  • Envoy and HAProxy are two proxies supported by AAP and have to be rightfully tested under the same test suite as other libraries (even if the underlying implementation for these proxies are done with the go tracer).
  • Proxies supports a different set of feature as of the go tracer and have their own versions that are not completely on par with the go tracer: so they need to have their own manifest file to keep track of the tests supported.

Changes

This PR made changes:

  • As there are 2 specific components with specific release process that supports tests on different versions, they now have their own unique manifest
  • Keeping scenarios that are both shared between these proxies with scenarios prefixed with GO_PROXIES_.
  • New/Changed scenarios:
    • go_proxies_default: everything that should fall into the default case of the proxies
    • go_proxies_appsec_blocking: executes the tests of the APPSEC_BLOCKING against proxies

Note: This could be confusing but, envoy and haproxy, are the two tested components and come with their own weblogs. Currently they only have one weblog per proxy, but this will be increased in the future.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2026

CODEOWNERS have been resolved as:

manifests/envoy.yml                                                     @DataDog/system-tests-core
manifests/haproxy.yml                                                   @DataDog/system-tests-core
.cursor/rules/repository-structure.mdc                                  @DataDog/system-tests-core
.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
run.sh                                                                  @DataDog/system-tests-core
tests/appsec/test_alpha.py                                              @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_blocking_addresses.py                                 @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_ip_blocking_full_denylist.py                          @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_reports.py                                            @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_request_blocking.py                                   @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_traces.py                                             @DataDog/asm-libraries @DataDog/system-tests-core
tests/appsec/test_versions.py                                           @DataDog/asm-libraries @DataDog/system-tests-core
tests/external_processing/test_apm.py                                   @DataDog/asm-libraries @DataDog/system-tests-core
tests/test_config_consistency.py                                        @DataDog/system-tests-core
tests/test_scrubbing.py                                                 @DataDog/system-tests-core
tests/test_semantic_conventions.py                                      @DataDog/system-tests-core
tests/test_standard_tags.py                                             @DataDog/system-tests-core
tests/test_the_test/test_compute_libraries_and_scenarios.py             @DataDog/system-tests-core
tests/test_the_test/test_group_rules.py                                 @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/go_proxies.py                                 @DataDog/system-tests-core
utils/_context/containers.py                                            @DataDog/system-tests-core
utils/manifest/_internal/parser.py                                      @DataDog/system-tests-core
utils/scripts/ci_orchestrators/workflow_data.py                         @DataDog/system-tests-core
utils/scripts/compute-workflow-parameters.py                            @DataDog/system-tests-core
utils/scripts/compute_libraries_and_scenarios.py                        @DataDog/system-tests-core
utils/scripts/get-image-list.py                                         @DataDog/system-tests-core
utils/scripts/libraries_and_scenarios_rules.yml                         @DataDog/system-tests-core
utils/scripts/load-binary.sh                                            @DataDog/system-tests-core
docs/scenarios/go_proxies_envoy_haproxy.md                              @DataDog/system-tests-core
utils/build/docker/envoy/envoy.yaml                                     @DataDog/system-tests-core

@cbeauchesne cbeauchesne self-requested a review January 15, 2026 21:14
@e-n-0 e-n-0 changed the title [golang_proxies] Create new manifest for go proxies [envoy / haproxy] Create new components manifests Jan 19, 2026
@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch 4 times, most recently from 87c8e7d to d253b47 Compare January 20, 2026 15:30
@e-n-0 e-n-0 marked this pull request as ready for review January 20, 2026 17:17
@e-n-0 e-n-0 requested review from a team as code owners January 20, 2026 17:17
@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch 2 times, most recently from 3ed55b9 to 4140af7 Compare January 22, 2026 19:27
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jan 22, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.appsec.api_security.test_schemas.Test_Scanners.test_request_method[spring-boot] from system_tests_suite (Datadog) (Fix with Cursor)
assert None

self = <tests.appsec.api_security.test_schemas.Test_Scanners object at 0x7ff0208099a0>

    def test_request_method(self):
        """Can provide request header schema"""
        schema_cookies = get_schema(self.request, "req.cookies")
        schema_headers = get_schema(self.request, "req.headers")
        assert self.request.status_code == 200
>       assert schema_cookies
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e7c1ca3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch 4 times, most recently from f0d47ee to 8855d57 Compare January 23, 2026 15:03
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting somewhere :)

The CI prod on happroxy (and also probably the other) is not using the last release, but a dev one. We can go though this together on monday.

@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch from 8855d57 to 180c90f Compare January 26, 2026 10:27
@e-n-0
Copy link
Copy Markdown
Member Author

e-n-0 commented Jan 26, 2026

Oops good catch, it was loading the dev version by default for haproxy (because at first on the old stream-offload-processing scenario, the tests were released before the haproxy integration was released)

@e-n-0 e-n-0 requested a review from cbeauchesne January 26, 2026 11:57
@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch from 180c90f to 008382e Compare January 27, 2026 10:35
@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch from 008382e to 3c3ad60 Compare January 27, 2026 16:09
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small cosmetic changes

Comment thread utils/_context/_scenarios/go_proxies.py Outdated
Comment thread utils/_context/_scenarios/go_proxies.py
@e-n-0 e-n-0 force-pushed the flavien/proxies/go-proxies-manifest branch from b26d380 to e7c1ca3 Compare January 27, 2026 19:37
@e-n-0 e-n-0 enabled auto-merge (squash) January 27, 2026 20:36
@e-n-0
Copy link
Copy Markdown
Member Author

e-n-0 commented Jan 27, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jan 27, 2026

View all feedbacks in Devflow UI.

2026-01-27 21:45:08 UTC ℹ️ Start processing command /merge


2026-01-27 21:45:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-27 22:43:38 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@e-n-0 e-n-0 merged commit b5f36ca into main Jan 27, 2026
2588 of 2590 checks passed
@e-n-0 e-n-0 deleted the flavien/proxies/go-proxies-manifest branch January 27, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants