Skip to content

chore(otel/logs): decouple creating logger from generating log messages#6116

Merged
mabdinur merged 1 commit into
mainfrom
munir/otel-logs-test-cleanup
Jan 27, 2026
Merged

chore(otel/logs): decouple creating logger from generating log messages#6116
mabdinur merged 1 commit into
mainfrom
munir/otel-logs-test-cleanup

Conversation

@mabdinur
Copy link
Copy Markdown
Contributor

Motivation

Decouple logger creation from log message generation to improve API clarity and flexibility.

Changes

  • Remove create_logger parameter from write_log API
  • Update write_log signature: logger_name, level, message (with optional span_id)
  • Add create_logger endpoint tests
  • Update all tests to call create_logger explicitly before write_log
  • Rename logger names in tests to match test function names

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/test_otel_logs.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/parametric/test_parametric_endpoints.py                           @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/build/docker/nodejs/parametric/server.js                          @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/python/parametric/apm_test_client/server.py          @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core
utils/docker_fixtures/_test_clients/_test_client_parametric.py          @DataDog/system-tests-core

@mabdinur mabdinur marked this pull request as ready for review January 26, 2026 19:45
@mabdinur mabdinur requested review from a team as code owners January 26, 2026 19:45
@mabdinur mabdinur requested review from christophe-papazian and removed request for a team January 26, 2026 19:45
@mabdinur mabdinur merged commit fd7ff72 into main Jan 27, 2026
413 checks passed
@mabdinur mabdinur deleted the munir/otel-logs-test-cleanup branch January 27, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants