add new configs from running update script#6117
Merged
Merged
Conversation
Contributor
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: cb57c63 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
bm1549
approved these changes
Jan 26, 2026
Contributor
This is because most languages do not use the system test and instead depend on the monitor that pings each of the guild channels. This will be alleviated soon as my team intends to automate the process of updating telemetry in dd-go, which would make this system test moot |
wantsui
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Jan 27, 2026
## Description <!-- Provide an overview of the change and motivation for the change --> I'm trying to get #16174 merged, but it's failing a test called trace completeness because the new env var didn't get registered: https://github.com/DataDog/dd-trace-py/actions/runs/21412462731/job/61653888559?pr=16174. ``` "(NOT A FLAKE) Read this quick runbook to update allowed configs: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness" ) E ValueError: (NOT A FLAKE) Read this quick runbook to update allowed configs: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness tests/test_telemetry.py:771: ValueError ------------------------------ Captured log call ------------------------------- 20:26:33.619 ERROR [ "DD_TRACE_LOG_LEVEL" ] ``` However, I just got the system test PR to pick up this env var merged in: DataDog/system-tests#6117, and since it's still failing, I believe this means I need to update the system tests reference in dd-trace-py. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
My Python PR is still failing tests: DataDog/dd-trace-py#16174 (comment)
Turns out from the GH test results that the telemetry test is still failing: https://github.com/DataDog/dd-trace-py/actions/runs/21373274678/job/61524248553?pr=16174
Changes
According to https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness, there's a script that's needed. When I run it, it added in a lot of missing configs that never got merged with this repo.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present