test(debugger): validate probe creation in expression language tests#6129
Merged
test(debugger): validate probe creation in expression language tests#6129
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
|
1c4dc12 to
d98c022
Compare
Add assertion to verify probes are created before validation. This allows the test to fail naturally with a meaningful error when probes cannot be created (e.g., Node.js lacks method probe support).
d98c022 to
25fe999
Compare
Contributor
Author
|
@nccatoni good point. I've updated the PR to do that now |
nccatoni
approved these changes
Feb 5, 2026
Collaborator
nccatoni
left a comment
There was a problem hiding this comment.
Thank you for the changes. LGTM, you might also want a review from someone familiar with the feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The
test_expression_language_contextual_variablestest was XPASS'ing for Node.jsChanges
Modified the test to validate the actual feature implementation instead of explicitly failing:
_assert()to verify probes are successfully created before validationThe test now:
@returnand@durationvaluesWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present