Skip to content

remove useless "default" scenario_group#6135

Merged
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/remove-default-group
Jan 28, 2026
Merged

remove useless "default" scenario_group#6135
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/remove-default-group

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne commented Jan 28, 2026

Motivation

this group name is very misleading. It was initially used to contains only the default scenario, since the CI orchestrator was able to handle only groups. But since it now also handles scenarios, it's not use anymore.

Changes

Per title

I also fixed a small typo in cCI orchestrator YAML

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/_context/_scenarios/core.py                                       @DataDog/system-tests-core
utils/_context/_scenarios/default.py                                    @DataDog/system-tests-core
utils/scripts/compute_libraries_and_scenarios.py                        @DataDog/system-tests-core
utils/scripts/libraries_and_scenarios_rules.yml                         @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jan 28, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 14 New flaky tests detected

tests.appsec.api_security.test_endpoint_discovery.Test_Endpoint_Discovery.test_single_is_first[flask-poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Expected one is_first=true payload, found 2
assert 2 == 1

self = <tests.appsec.api_security.test_endpoint_discovery.Test_Endpoint_Discovery object at 0x7fa6591f0aa0>

    def test_single_is_first(self):
        """Verify that the is_first flag appears exactly once in telemetry.
    
        Mandatory for the feature.
        """
...
tests.test_config_consistency.Test_Config_UnifiedServiceTagging_CustomService.test_specified_service_name[haproxy-spoa] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: No trace has been found for request YYRAZSYECLNBOWLIKZRYIZNVMQKZCYUJZZOO

self = <tests.test_config_consistency.Test_Config_UnifiedServiceTagging_CustomService object at 0x7f15f0b20e30>

    @irrelevant(
        library="golang",
        weblog_variant="gin",
        reason="A custom service name is specified on the gin integration, causing a conflict",
    )
    def test_specified_service_name(self):
...
tests.test_library_logs.Test_NoExceptions.test_java_logs[spring-boot-openliberty] from system_tests_suite (Datadog) (Fix with Cursor)
self = <tests.test_library_logs.Test_NoExceptions object at 0x7f9fc4fb7170>

    @irrelevant(context.library != "java", reason="only for Java")
    def test_java_logs(self):
        """Test Java logs for unexpected errors."""
        disallowed_patterns = [
            r".*ERROR.*",
        ]
        allowed_patterns = [
            r".*"
...
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 884e372 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cbeauchesne cbeauchesne marked this pull request as ready for review January 28, 2026 17:07
@cbeauchesne cbeauchesne requested a review from a team as a code owner January 28, 2026 17:07
@cbeauchesne cbeauchesne merged commit f5ea7f9 into main Jan 28, 2026
1978 of 1982 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/remove-default-group branch January 28, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant