Skip to content

removing irrelevant waf addresses tests#6136

Merged
christophe-papazian merged 1 commit into
mainfrom
christophe-papazian/removing_irrelevant_tests
Jan 28, 2026
Merged

removing irrelevant waf addresses tests#6136
christophe-papazian merged 1 commit into
mainfrom
christophe-papazian/removing_irrelevant_tests

Conversation

@christophe-papazian
Copy link
Copy Markdown
Contributor

Motivation

Removing tests that are irrelevant for years now.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/cpp_nginx.yml                                                 @DataDog/system-tests-core
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/appsec/waf/test_addresses.py                                      @DataDog/asm-libraries @DataDog/system-tests-core

@christophe-papazian christophe-papazian marked this pull request as ready for review January 28, 2026 15:34
@christophe-papazian christophe-papazian requested review from a team as code owners January 28, 2026 15:34
@christophe-papazian christophe-papazian requested review from claponcet, gnufede, manuel-alvarez-alvarez and r1viollet and removed request for a team January 28, 2026 15:34
@christophe-papazian christophe-papazian merged commit 52007f3 into main Jan 28, 2026
428 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/removing_irrelevant_tests branch January 28, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants