resource renaming: fix failing resource renaming test for java

[florentinl]

Motivation

After monitoring the test for a few days, I noticed that it is still only failing for two Java flavors (play and ratpack).

The reason is that they create multiple web spans in their trace tree and stats points where double counted.

            {
              "Name": "akka-http.request",
              "Service": "weblog",
              "Resource": "GET /resource_renaming/api/users/{param:int}",
              "Type": "web",
              "HTTPStatusCode": 200,
              "Synthetics": false,
              "IsTraceRoot": 1,
              "SpanKind": "server",
              "HTTPMethod": "GET",
              "HTTPEndpoint": "/resource_renaming/api/users/{param:int}",
              "Hits": 5,
              "TopLevelHits": 5,
            },
            {
              "Name": "play.request",
              "Service": "weblog",
              "Resource": "GET /resource_renaming/api/users/{param:int}",
              "Type": "web",
              "HTTPStatusCode": 0,
              "Synthetics": false,
              "IsTraceRoot": 2,
              "SpanKind": "server",
              "HTTPMethod": "GET",
              "HTTPEndpoint": "/resource_renaming/api/users/{param:int}",
              "Hits": 5,
              "TopLevelHits": 0,
            },

Switching to TopLevelHits instead of Hits should fix the issue.

This allows us to enable the test again.

Changes

• use TopLevelHits instead of Hits

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
tests/test_resource_renaming.py                                         @DataDog/system-tests-core

[jandro996]

LGTM! Thanks!