Skip to content

C++ parametric: support multi-arch builds with TARGETARCH#6498

Open
bm1549 wants to merge 1 commit intomainfrom
brian.marks/cpp-parametric-arm-support
Open

C++ parametric: support multi-arch builds with TARGETARCH#6498
bm1549 wants to merge 1 commit intomainfrom
brian.marks/cpp-parametric-arm-support

Conversation

@bm1549
Copy link
Contributor

@bm1549 bm1549 commented Mar 13, 2026

Motivation

Split out from #6495. The C++ parametric Dockerfile hardcodes amd64 in the base image tag, which prevents building on ARM (Apple Silicon) machines.

Changes

  • Use Docker's built-in TARGETARCH build arg (defaulting to amd64) instead of hardcoding the architecture in the FROM line, so the image builds correctly on both x86_64 and ARM.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

🤖 Generated with Claude Code

Use Docker's TARGETARCH build arg instead of hardcoding amd64 in the
C++ parametric base image tag, so the image builds correctly on ARM
(Apple Silicon) as well.

Split out from #6495.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/cpp/parametric/Dockerfile                            @DataDog/dd-trace-cpp @DataDog/system-tests-core

@bm1549 bm1549 marked this pull request as ready for review March 13, 2026 19:00
@bm1549 bm1549 requested review from a team as code owners March 13, 2026 19:00
@bm1549 bm1549 requested review from xlamorlette-datadog and removed request for a team March 13, 2026 19:00
bm1549 added a commit that referenced this pull request Mar 13, 2026
The multi-arch TARGETARCH change for the C++ parametric Dockerfile has
been moved to a separate PR (#6498) to keep this PR focused on .NET,
PHP, and Python ARM Mac support.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant