Skip to content

Update Node.js telemetry to use canonical names#6536

Merged
BridgeAR merged 7 commits intomainfrom
BridgeAR/2026-03-19-update-nodejs-telemetry
Mar 27, 2026
Merged

Update Node.js telemetry to use canonical names#6536
BridgeAR merged 7 commits intomainfrom
BridgeAR/2026-03-19-update-nodejs-telemetry

Conversation

@BridgeAR
Copy link
Copy Markdown
Member

Motivation

The telemetry format is planned to change to use the canonical env form instead of unique ones. This also fixes a TODO by fixing the reported telemetry key.

Changes

The keys are updated properly.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

CODEOWNERS have been resolved as:

tests/appsec/test_asm_standalone.py                                     @DataDog/asm-libraries @DataDog/system-tests-core
tests/docker_ssi/test_docker_ssi_appsec.py                              @DataDog/system-tests-core
tests/parametric/test_telemetry.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/test_telemetry.py                                                 @DataDog/libdatadog-telemetry @DataDog/apm-sdk-capabilities @DataDog/system-tests-core
utils/telemetry_utils.py                                                @DataDog/system-tests-core

The telemetry format is planned to change to use the canonical env
form instead of unique ones. This also fixes a TODO by fixing the
reported telemetry key.

Mostly both formats are accepted for now. For rate limit it seems
best to generally accept integers as well as strings.
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-03-19-update-nodejs-telemetry branch from 1469465 to 0b160e2 Compare March 27, 2026 13:34
@BridgeAR BridgeAR marked this pull request as ready for review March 27, 2026 14:35
@BridgeAR BridgeAR requested review from a team as code owners March 27, 2026 14:35
@BridgeAR BridgeAR requested review from mabdinur and pawelchcki and removed request for a team March 27, 2026 14:35
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Mar 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6f684d6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efc5bb5d52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@BridgeAR BridgeAR marked this pull request as draft March 27, 2026 14:43
@BridgeAR BridgeAR marked this pull request as draft March 27, 2026 14:43
@BridgeAR BridgeAR marked this pull request as ready for review March 27, 2026 17:22
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb9fa9a9c9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@BridgeAR BridgeAR enabled auto-merge (squash) March 27, 2026 20:22
@BridgeAR BridgeAR merged commit f3bcc49 into main Mar 27, 2026
2656 of 2662 checks passed
@BridgeAR BridgeAR deleted the BridgeAR/2026-03-19-update-nodejs-telemetry branch March 27, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants