Skip to content

Mark to test as missing_feature (incorrect mark before)#6587

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/fix-go-manifest
Mar 25, 2026
Merged

Mark to test as missing_feature (incorrect mark before)#6587
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/fix-go-manifest

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne commented Mar 25, 2026

Motivation

Those change activated tests for go 2.7.0-dev. An issue in version comparizon makes those activation ineffective, and turns out that those tests are not passing.

Changes

Mark those tests as missing_feature

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
utils/build/docker/golang/install_ddtrace.sh                            @DataDog/dd-trace-go-guild @DataDog/system-tests-core

@cbeauchesne cbeauchesne marked this pull request as ready for review March 25, 2026 14:08
@cbeauchesne cbeauchesne requested review from a team as code owners March 25, 2026 14:08
@cbeauchesne cbeauchesne enabled auto-merge (squash) March 25, 2026 14:09
@cbeauchesne cbeauchesne merged commit b24174f into main Mar 25, 2026
260 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/fix-go-manifest branch March 25, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants