[java] re-enable Test_Knuth_Sample_Rate for >=1.61.1#6711
Merged
Conversation
The _dd.p.ksr formatting bug (APMAPI-1880) was fixed in dd-trace-java by switching from 6 significant figures to 6 decimal places. The fix will ship in v1.61.1. Removes the `bug (APMAPI-1880)` override and sets the minimum version to >=1.61.1 so the test runs against fixed releases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
|
bm1549
changed the title
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 5924ad4 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
mhlidd
approved these changes
Apr 9, 2026
Contributor
mhlidd
left a comment
mhlidd
left a comment
There was a problem hiding this comment.
Isn't this the same as just leaving v1.61.1
Contributor
Author
Yeah. This is following other conventions though, so probably okay for this! |
Member
|
This seems to cause the test to consistently fail: e.g., https://github.com/DataDog/system-tests/actions/runs/24565965626/job/71826446518 |
Contributor
Author
|
@BridgeAR it looks like there was a patch release I didn't know about and my PR didn't make it on that trainhttps://github.com/DataDog/dd-trace-java/pull/11068 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
_dd.p.ksrformatting bug (APMAPI-1880) was fixed in dd-trace-java via DataDog/dd-trace-java#11068. The fix ships in v1.61.1 (if done) or v1.62.0Changes
Removes the
bug (APMAPI-1880)override ontest_sampling_knuth_sample_rate_trace_sampling_ruleand replaces it with>=1.61.1so the test runs against fixed releases.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present