[nodejs] fix local dd-trace linking regression#6728
Merged
Conversation
Replace `npm link` with a direct symlink to the mounted `dd-trace-js` checkout in the Node.js system test images. This restores local tracer linking after `@dd-trace-js/package.json` started requiring link-time scripts that broke the previous workflow.
Contributor
|
|
cbeauchesne
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Local linking of the Node.js tracer in
system-testsregressed after@dd-trace-js/package.jsonstarted to include scripts that run duringnpm link. Our local test workflow depended onnpm linkagainst the mounteddd-trace-jscheckout, so Node.js system test images stopped picking up local tracer changes reliably.Changes
Replace the
npm link/npm link dd-traceflow with a direct symlink from/usr/app/node_modules/dd-traceto/volumes/dd-trace-js.Apply the same fix across the shared Node.js startup scripts and the Node.js
system_tests_library_version.shscripts used by the Anthropic, Google GenAI, OpenAI, and parametric test apps.This restores local tracer linking while avoiding link-time package scripts in the mounted
dd-trace-jscheckout.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present