Skip to content

Disable Code Origin by default in FastAPI#6744

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
fastapi-disable-code-origin
Apr 14, 2026
Merged

Disable Code Origin by default in FastAPI#6744
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
fastapi-disable-code-origin

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Motivation

We are making Code Origin enabled by default and some of the existing FastAPI tests fail because of the new code origin tags that are not expected in payloads. Relevant scenarios still enable code origin explicitly, so this is essentially a no-op compared to the current configuration defaults.

Changes

We disable Code Origin by default in FastAPI to allow most of the scenario that expect specific payloads to avoid receiving unexpected code origin tags that would make the tests fail. Because Code Origin was originally off by default, the scenarios that test that feature explicitly enable it already, so this is effectively a no-op.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

We are making Code Origin enabled by default and some of the
existing FastAPI tests fail because of the new code origin tags
that are not expected in payloads. Relevant scenarios still enable
code origin explicitly, so this is essentially a no-op compared to
the current configuration defaults.
@P403n1x87 P403n1x87 requested review from a team as code owners April 14, 2026 13:43
@P403n1x87 P403n1x87 requested review from florentinl and gnufede and removed request for a team April 14, 2026 13:43
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/python/fastapi.Dockerfile                            @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34d2e138bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/build/docker/python/fastapi.Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants