Skip to content

[nodejs] renable skipped debugger tests#6817

Merged
watson merged 1 commit intomainfrom
watson/unskip-node-tests
Apr 29, 2026
Merged

[nodejs] renable skipped debugger tests#6817
watson merged 1 commit intomainfrom
watson/unskip-node-tests

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Apr 27, 2026

Motivation

A handful of Node.js debugger system tests were marked as bug in manifests/nodejs.yml even though they now pass against the current dd-trace-js debugger pipeline (since release v5.85.0).

Changes

  • Re-enable previously skipped debugger tests for nodejs in manifests/nodejs.yml

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team — N/A, only manifests/nodejs.yml is touched.
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

Copy link
Copy Markdown
Contributor Author

watson commented Apr 27, 2026

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

@watson watson force-pushed the watson/unskip-node-tests branch from 99aa6d3 to 19a11f3 Compare April 28, 2026 04:01
@watson watson force-pushed the watson/debugger-v2-schema-test branch from e66b229 to 29283ca Compare April 28, 2026 04:01
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 28, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b6580cf | Docs | Datadog PR Page | Give us feedback!

@watson watson force-pushed the watson/debugger-v2-schema-test branch from 29283ca to 6b52ec8 Compare April 28, 2026 10:01
@watson watson force-pushed the watson/unskip-node-tests branch from 19a11f3 to 328b396 Compare April 28, 2026 10:01
@watson watson force-pushed the watson/debugger-v2-schema-test branch from 6b52ec8 to 6f3577a Compare April 29, 2026 08:37
@watson watson force-pushed the watson/unskip-node-tests branch from 328b396 to 691b144 Compare April 29, 2026 08:37
Base automatically changed from watson/debugger-v2-schema-test to main April 29, 2026 17:46
@watson watson force-pushed the watson/unskip-node-tests branch from 691b144 to b6580cf Compare April 29, 2026 17:49
@watson watson marked this pull request as ready for review April 29, 2026 17:49
@watson watson requested a review from a team as a code owner April 29, 2026 17:49
@watson watson enabled auto-merge (squash) April 29, 2026 17:56
@watson watson merged commit 925630a into main Apr 29, 2026
42 checks passed
@watson watson deleted the watson/unskip-node-tests branch April 29, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants