[java] Enable Test_FFE_Eval_Metric_Count::test_ffe_eval_metric_count for v1.63.0#7236
Merged
Merged
Conversation
Contributor
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a0ddf0f20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…for v1.63.0 The FFL-1972 fix shipped in dd-trace-java v1.63.0 via DataDog/dd-trace-java#11426, so gate the test to spring-boot v1.63.0 rather than letting it inherit the file-level v1.62.0 declaration — the fix is absent from v1.62.0.
sameerank
force-pushed
the
sameeran/enable-ffe-eval-metric-count
branch
from
4a0ddf0 to
ecb7974
Compare
sameerank
changed the title
sameerank
commented
Jun 30, 2026
| tests/ffe/test_flag_eval_metrics.py::Test_FFE_Eval_Metric_Count::test_ffe_eval_metric_count: | ||
| - weblog_declaration: | ||
| "*": irrelevant | ||
| spring-boot: v1.63.0 |
Contributor
Author
There was a problem hiding this comment.
Fixed in https://github.com/DataDog/dd-trace-java/releases/tag/v1.63.0
🐛 use delta temporality for OTLP metrics export (DataDog/dd-trace-java#11426 - @sameerank)
claponcet
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tests/ffe/test_flag_eval_metrics.py::Test_FFE_Eval_Metric_Count::test_ffe_eval_metric_countwas marked as a known bug (FFL-1972) in the Java manifest. The fix shipped in dd-trace-java v1.63.0 via DataDog/dd-trace-java#11426 ("fix(openfeature): use delta temporality for OTLP metrics export", merged 2026-05-22).Change
Replace the
bug (FFL-1972)marker with a version gate at the release that contains the fix:The fix is present in
v1.63.0and absent fromv1.62.0(verified: the #11426 merge commit is an ancestor of thev1.63.0tag but notv1.62.0). Gating tov1.63.0— rather than letting the test inherit the file-levelspring-boot: v1.62.0declaration — avoids asserting the test passes onv1.62.0, where the bug is still present.This addresses the automated review note about gating activation to the fixed version.