Merged
Conversation
jirhiker
requested changes
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. |
jirhiker
requested changes
Sep 10, 2025
Member
jirhiker
left a comment
There was a problem hiding this comment.
Is this PR up to date with the transfer branch?
|
|
||
| if init or transfer_well_flag: | ||
| print("\n", "*" * 10, "TRANSFERRING WELLS", "*" * 10) | ||
| msg = "*" * 10 + "TRANSFERRING WELLS" + "*" * 10 |
Member
There was a problem hiding this comment.
message("TRANSFERRING WELLS")
def message(msg, pad='*', pad_len=10):
pad *= pad_len
logger.info(f"{pad} {msg} {pad}")
Contributor
Author
There was a problem hiding this comment.
I didn't know of the transfer branch... I've just been working off of pre-production assuming that was the base for all of the project. Is that message function the only update? If so, I can also merge transfer into my branch, make updates/resolve conflicts, and push back to this PR
Member
There was a problem hiding this comment.
the other updates are to allow transfers to run via Cloud Run
jirhiker
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?
infofor print statements andwarningfor when something goes wrong. Should we differentiate betweenwarninganderror?