BDMS 221: updates to pass tests

[jacob-a-brown]

the updates herein enable the tests to pass all tests except for @then("the response should include the source of the well depth information") since the polymorphic source table is still in development. I've made changes in a variety of places. The only changes I made to models is to fix some lexicon terms and add @property fields to the thing model. Otherwise the work has been done in schemas and the testing directory

[TylerAdamMartinez]

Suggested change

	measuring_point_height: float
	measuring_point_height: float | None

[jacob-a-brown]

measuring_point_height is required for every water level measurement to get depth of water below ground surface. Why do you think it should be optional?

[TylerAdamMartinez]

Because the transfer script results in some rows having a NULL in the measuring_point_height field, leading to a 500 error when I request it.

[jacob-a-brown]

Got it 👍 . The updates I have made to the transfer scripts now require a measuring_point_height for every well. That's in another PR... (PR #242 )

[jacob-a-brown]

@ksmuczynski and @jirhiker, @TylerAdamMartinez came across an error that I didn't anticipate:

I changed line 183 to alternate_organization: Organization (a restricted list of enums). I made this update because of the name of the field. In the script transfers/link_id_transfer.py, however, PLSS data is being added as alternate IDs and the alternate_organization is being set to PLSS. This is not an organization in our lexicon term table. My questions are:

1. Should the field alternate_organization be restricted to the enums? If so, should PLSS be added to as an organization to the lexicon (even though it isn't really)?
2. Should the name of the field alternate_organization change so that PLSS can be added? If so, should the field be a string or an enum?

[jirhiker]

@ksmuczynski and @jirhiker, @TylerAdamMartinez came across an error that I didn't anticipate:

I changed line 183 to alternate_organization: Organization (a restricted list of enums). I made this update because of the name of the field. In the script transfers/link_id_transfer.py, however, PLSS data is being added as alternate IDs and the alternate_organization is being set to PLSS. This is not an organization in our lexicon term table. My questions are:

1. Should the field alternate_organization be restricted to the enums? If so, should PLSS be added to as an organization to the lexicon (even though it isn't really)?
2. Should the name of the field alternate_organization change so that PLSS can be added? If so, should the field be a string or an enum?

For the sake of expediency add PLSS as an alternate_organization to the lexicon