transfer #268
Merged
transfer #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeping the organization mapping in a single file is easier for maintenance and to standardize names in Ocotillo since it'll enable quick comparisons
this uses the new single table rather than two tables that contain the same information
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
|
jacob-a-brown
approved these changes
Dec 4, 2025
Contributor
jacob-a-brown
left a comment
jacob-a-brown
left a comment
There was a problem hiding this comment.
Besides codex' comments about chunk_by_size I think that it looks good. I need to head out for the evening, and we are trying to get the transfer initiated tonight, so I'm approving it so it can be merged and transferred after codex' comments are addressed (whether changes need to be made or not)
…g in water levels transfer
use SFC for all santa fe county organizations for standardized nomenclature
this was originally used and I removed it in the refactor. I added it back to ensure validation errors are caught if an organization is not in the lexicon
this is the nomenclature used by AMP and in the feature files, so this change improves consistency across the codebase and teams
…water levels transfer
This field used to be standalone, but with the creation and implementation of the polymorphic notes table it has been moved there
It used to be called "Other" but has been changed to "General"
The feature file requests specific note types. By returning all notes at once, duplicate entries will be returned. Furthermore, some note types only apply to specific thing types. So, general notes are returned for all thing types, but then for each thing type specific notes will be returned
Use consistent naming conventions for organizations in lexicon and data mapper.
… enhancing logging
…fault None handling
…nhance error logging
…ing in pre-commit config
…n transfer process
…n transfer process
…tion-speed-of-welltransferer Stream after-hook processing in WellTransferer
… in transfer process
…sfer-and-updates BDMS 233: notes transfer and updates
…and session management
…and add test cases
…est files for clarity
…es and refactor measuring point height validation
…handling in photo retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?