[NO TICKET ] Mv guard & logger up before list() to prevent crashes in transfers/profiling.py #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAdamMartinez
requested review from
chasetmartin,
jirhiker,
kbighorse and
ksmuczynski
TylerAdamMartinez
force-pushed
the
TAM-profiling-patch
branch
from
cafbbdd to
ea411d2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in upload_profile_artifacts() that occurred when profiling artifacts were None, causing a TypeError: 'NoneType' object is not iterable.
Changes:
- Updated function signature to accept
Optional[Iterable[ProfileArtifact]] - Added early-return guard before converting artifacts to a list
- Moved
list(artifacts)call after the None/empty check
chasetmartin
approved these changes
Jan 23, 2026
Collaborator
chasetmartin
left a comment
chasetmartin
left a comment
There was a problem hiding this comment.
looks good. @jirhiker Just tagging you since the profiler is your recent addition so you see this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem/context:
upload_profile_artifacts()could crash withTypeError: 'NoneType' object is not iterablewhen profiling artifacts were not present.How
Implementation summary - the following was changed/added/removed:
upload_profile_artifactsto acceptOptional[Iterable[ProfileArtifact]]instead of requiring an iterableNone/empty artifacts and logged a helpful message when there’s nothing to upload.list(artifacts)conversion to occur only after theNone/empty check to avoid exceptions.Notes
Any special considerations, workarounds, or follow-up work to note?