BDMS-773 Fix hydrograph stale data when switching wells#262
Merged
jeremyzilar merged 1 commit intostagingfrom Apr 27, 2026
Merged
BDMS-773 Fix hydrograph stale data when switching wells#262jeremyzilar merged 1 commit intostagingfrom
jeremyzilar merged 1 commit intostagingfrom
Conversation
Drive thing_id from React Query queryKey inside the hydrograph queryFn, forward AbortSignal through ocotillo getList and axios, show loading while the query is pending, and remount the chart when the well id changes. Add .cursor to gitignore for local Cursor metadata.
Preview DeploymentPreview URL: https://preview-bdms-773-auejgdbofq-uc.a.run.app Note: This preview uses the staging API endpoints. |
Contributor
Author
|
This seems to be working on the Preview branch |
jirhiker
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changing
Fixes the hydrograph showing the previous well's series after client-side navigation (for example from a well with observations to one with none) until a full refresh.
Changes
thing_idfrom the React QueryqueryKeyinside the hydrographqueryFnso list requests always match the active well key (avoids stale closure behavior).AbortSignalfrom TanStack Query throughgetListmeta to axios so in-flight pagination requests cancel when the route id changes.isPendingfor the hydrograph card loading state instead ofisLoadingso the UI waits for the first result for the new key.<Hydrograph />withkey={well.id}so ECharts resets when the well changes..cursorto.gitignoreso local Cursor IDE metadata stays out of the repo.Manual QA
Navigate between two wells where one has hydrograph data and one does not; confirm the chart or empty state matches the current well without refreshing.