Skip to content

eodtime bugfix#31

Merged
picoDoc merged 7 commits intomasterfrom
eodtime_bugfix
Jan 18, 2017
Merged

eodtime bugfix#31
picoDoc merged 7 commits intomasterfrom
eodtime_bugfix

Conversation

@jonathonmcmurray
Copy link
Copy Markdown
Member

No description provided.

@picoDoc picoDoc requested review from jonnypress and picoDoc January 16, 2017 17:20
Comment thread code/processes/tickerplant.q Outdated
tick:{init[];if[not min(`time`sym~2#key flip value@)each t;'`timesym];@[;`sym;`g#]each t;d::.eodtime.d;if[l::count y;L::`$":",y,"/",x,10#".";l::ld d]};

endofday:{end d;d+:1;icounts::()!();.eodtime.nextroll:.eodtime.getroll[.z.p];.eodtime.dailyadj:.eodtime.getdailyadjustment[];if[l;hclose l;l::0(`.u.ld;d)]};
endofday:{end d;d+:1;icounts::()!();if[.z.p>.eodtime.nextroll:.eodtime.getroll[.z.p];system"t 0";'"next roll is in the past, check config"];.eodtime.dailyadj:.eodtime.getdailyadjustment[];if[l;hclose l;l::0(`.u.ld;d)]};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should say check config here, is there any configuration that could generate this problem? This is really just meant as a precaution, since the repeating rollover is such as disaster.

Comment thread docs/utilities.md

The default configuration sets both timezones to GMT and has the rollover
performed at midnight.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention that a list of availble timezones can be found in .tz.t?

@picoDoc
Copy link
Copy Markdown
Collaborator

picoDoc commented Jan 16, 2017

added some comments

@jonathonmcmurray
Copy link
Copy Markdown
Member Author

@picoDoc fixed the stuff in the above comments

@picoDoc
Copy link
Copy Markdown
Collaborator

picoDoc commented Jan 17, 2017

looks good to me. Could you fix the conflicts with the docs on master?

@picoDoc picoDoc merged commit 4fa3825 into master Jan 18, 2017
FlyingOE pushed a commit to FlyingOE/TorQ that referenced this pull request Mar 10, 2017
* 'master' of https://github.com/AquaQAnalytics/TorQ: (95 commits)
  Fixed issue where eod would fail when wdb was set to partbyattr and t… (DataIntellectTech#42)
  Mergereplay (DataIntellectTech#41)
  Preventing tabsizes appearing in hdb (DataIntellectTech#39)
  Subcut (DataIntellectTech#38)
  Added fix to .email.senddefault to terminate if no connection to server (DataIntellectTech#37)
  added passwords dictionary for connecting to non torq processes and modified opencon function (DataIntellectTech#36)
  Blog page and short descriptions of previously unmentioned files (DataIntellectTech#35)
  Documentation kdbappcode (DataIntellectTech#34)
  updated to 3.0.0
  added ldap permissioning
  Ldap (DataIntellectTech#29)
  eodtime bugfix, improved error catching at rollover (DataIntellectTech#31)
  Update utilities.md with comments on API table generation (DataIntellectTech#33)
  Docsite (DataIntellectTech#32)
  Delete Documentation pdf (DataIntellectTech#30)
  Readme update (DataIntellectTech#28)
  Mkdocs site details (DataIntellectTech#27)
  Added permissions.q to the documentation (DataIntellectTech#25)
  Permissions (DataIntellectTech#24)
  Improved debugging features  (DataIntellectTech#23)
  ...
@jonnypress jonnypress deleted the eodtime_bugfix branch February 1, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants