Skip to content

Renaming of timezone to tz#91

Open
matthewv192 wants to merge 2 commits into
DataIntellectTech:mainfrom
matthewv192:main
Open

Renaming of timezone to tz#91
matthewv192 wants to merge 2 commits into
DataIntellectTech:mainfrom
matthewv192:main

Conversation

@matthewv192
Copy link
Copy Markdown

Renamed all instances of timezone to tz with passing unit tests

@matthewv192
Copy link
Copy Markdown
Author

image

di/timezone/ → di/tz/ — module directory renamed (carries init.q, test.csv, config/tzinfo)
di/tz/timezone.md → di/tz/tz.md — doc renamed, plus use lines and config path updated to di.tz
di/tz/test.csv — before row's usedi.timezone→ now usedi.tz
di/k4unit/k4unit.md — example updated from di.timezone to di.tz

Comment thread di/k4unit/k4unit.md Outdated
```

As part of the test cases it rquires the "before" test to module load the module with the same naming convention used for the tests, in this case "timezone":
As part of the test cases it rquires the "before" test to module load the module with the same naming convention used for the tests, in this case "tz":
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rquires typo

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Copy Markdown
Contributor

@alowrydi alowrydi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename looks complete and consistent. All references to di.timezone updated to di.tz across init.q, test.csv, tz.md, and k4unit.md
Just one small existing typo in k4unit.md I left a comment on.

Corrected a typo in the k4unit documentation regarding the 'before' test requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants