Relax requirement for description and mode fields on a new node.#1418
Merged
Relax requirement for description and mode fields on a new node.#1418
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR makes the description field optional and defaults mode to published for new nodes, and adds tests to verify creating metrics without explicitly providing those fields.
- Changed
MutableNodeFieldsandCubeNodeFieldssodescriptionis optional and added a defaultmodeinMutableNodeFields. - Introduced tests in
metrics_test.pyto ensure nodes can be created withoutdescriptionormode.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datajunction-server/datajunction_server/models/node.py | Made description optional in both models and set default mode in mutable fields |
| datajunction-server/tests/api/metrics_test.py | Added tests for creating metrics without specifying description or mode |
Comments suppressed due to low confidence (2)
datajunction-server/datajunction_server/models/node.py:666
- For consistency with
MutableNodeFields, consider givingmodea default value here (e.g.,mode: NodeMode = NodeMode.PUBLISHED).
mode: NodeMode
datajunction-server/tests/api/metrics_test.py:1310
- After asserting the status code, add checks for the response body to confirm
modedefaults to 'published' and thatdescriptionis handled (e.g.,assert response.json()["mode"] == "published").
assert response.status_code == 201
shangyian
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For mode: just use
publishedas the default value.Test Plan
Unit tests.
make checkpassesmake testshows 100% unit test coverageDeployment Plan
Auto.