Skip deactivated nodes in namespace export.#1419
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the namespace export functionality so that deactivated nodes are no longer included in the output.
- Adds a filter on
deactivated_atto skip deactivated nodes in the internal query - Enhances the export test to deactivate a node and verify it’s omitted
- Adjusts the expected file list in the export test to comment out the deactivated node
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| datajunction-server/datajunction_server/internal/namespaces.py | Filters out nodes where deactivated_at is set |
| datajunction-server/tests/api/namespaces_test.py | Deactivates a node in test and removes its entry from expected list |
agorajek
force-pushed
the
project-pull-bug-fix
branch
from
eb16df1 to
1af68bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Because we should.
Test Plan
Unit tests and some manual calls.
make checkpassesmake testshows 100% unit test coverageDeployment Plan
Auto.