Add caching for node and metrics SQL + reorganize #1482
Merged
shangyian merged 6 commits intoDataJunction:mainfrom Sep 2, 2025
Merged
Add caching for node and metrics SQL + reorganize #1482shangyian merged 6 commits intoDataJunction:mainfrom
shangyian merged 6 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
shangyian
force-pushed
the
cache-node-sql
branch
2 times, most recently
from
6b3eef5 to
a29686d
Compare
shangyian
force-pushed
the
cache-node-sql
branch
from
f12b4de to
8cd4791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds additional caching for SQL generation, specifically for node SQL and metrics SQL. It also does some clean up to remove much of the original
QueryRequestcaching and reorganizes the SQL generation functions into a singleinternal.sqlmodule.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan