Add support for service accounts#1485
Merged
shangyian merged 9 commits intoDataJunction:mainfrom Sep 4, 2025
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
service-account
branch
2 times, most recently
from
7164852 to
7820c3f
Compare
shangyian
force-pushed
the
service-account
branch
2 times, most recently
from
1c84bd3 to
2c2c872
Compare
shangyian
force-pushed
the
service-account
branch
from
f2900ba to
1aec526
Compare
agorajek
reviewed
Sep 4, 2025
Member
agorajek
left a comment
agorajek
left a comment
There was a problem hiding this comment.
Ah, forgot to review yday... just added one question inline.
| nullable=True, | ||
| ) | ||
|
|
||
| created_by: Mapped["User"] = relationship("User") |
Member
There was a problem hiding this comment.
How is this different from created_by_id ?
Collaborator
Author
There was a problem hiding this comment.
This is the ORM reference to the User object, similar to how created_nodes works on the user class as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for service accounts, which will enable programmatic clients to authenticate and interact with DJ. This setup has service accounts modeled as a part of the
userstable for simplicity, and they're identified with thekindflag. Any given service account has to be created with an authenticated identity, which is represented by thecreated_by_idfield.This change includes API endpoints for:
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan