Skip to content

Speed up creating nodes#1495

Merged
shangyian merged 5 commits intoDataJunction:mainfrom
shangyian:speed-up-create-node
Sep 13, 2025
Merged

Speed up creating nodes#1495
shangyian merged 5 commits intoDataJunction:mainfrom
shangyian:speed-up-create-node

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

@shangyian shangyian commented Sep 12, 2025

Summary

This PR has a series of minor changes that each amount to a small speed-up in creating a new node:

  • Reduce the number of database calls when setting the primary key columns
  • Push deriving frozen measures into an async background task so that it doesn't block a response on metric node creation
  • Various AST optimizations, including compiling in a threadpool

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 12, 2025

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 5a213cd
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/68c52d7f049430000861ee6f

@shangyian shangyian marked this pull request as ready for review September 13, 2025 15:16
@shangyian shangyian merged commit 08c810c into DataJunction:main Sep 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant