Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
agorajek
force-pushed
the
from-alpha-to-patch
branch
from
9bb9398 to
c4deeab
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR switches the default version bumping pattern from alpha releases to patch releases for all components in the monorepo.
- Changes default bump type from
alphatopatchin the workflow dispatch inputs - Updates environment variable default to use
patchinstead ofalpha - Comments out the documentation build step that runs after patch releases
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/version-bump.yml
Outdated
| # working-directory: ./docs | ||
| # if: ${{ env.bump-type == 'major' || env.bump-type == 'minor' || env.bump-type == 'patch'}} | ||
| # run: | | ||
| # ./build-docs.sh $NEW_VERSION true |
There was a problem hiding this comment.
Hey @samredai and @shangyian . This command fails because there is a 3rd argument missing for BASE_URL, but this never ran for the alpha releases so I temporarily commented it out. I am not sure what's the best fix here, but I think I am missing how we updated the docs so far.
There was a problem hiding this comment.
@agorajek I don't believe we actually need this command. Instead, just running npm run build will build the docs, and npm run build -- -b $DEPLOY_URL will set them up to be deployed.
There was a problem hiding this comment.
Agree. I deleted this section.
agorajek
force-pushed
the
from-alpha-to-patch
branch
from
2e1c503 to
78a76b4
Compare
Summary
This PR switches our release pattern from
alphatopatch.Test Plan
Tested with manual run: #1498
make checkpassesmake testshows 100% unit test coverageDeployment Plan
Auto.