Merged
Conversation
…oyed make cube deployment part of singular commit
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change results in faster deployments for multiple cubes, and also prevents partial deployments via atomic commits.
The cube deployment flow is refactored here to use an atomic transaction-based approach instead of individual deployments per cube. This means that cubes now deploy through the same flow as other node types in a single DB transaction - they either all succeed or all fail together.
This change also sets up bulk validation for cubes, where we batch load all metrics/dimensions across cubes at once and then validate per-cube to provide cube-level feedback on failing configs.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan