Optimize DJ SQL and fix Trino compatibility#1711
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Jan 26, 2026
Merged
Optimize DJ SQL and fix Trino compatibility#1711shangyian merged 3 commits intoDataJunction:mainfrom
shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/djsql/endpoint by removing redundant validation. Validation is now delegated tobuild_metrics_sql(), avoiding duplicate work./djsql/endpoint andbuild_metrics_sql()rather than defaulting to Spark when not specified. DJ will try to infer an appropriate dialect based on the catalogs of the available tables.COALESCE(Trino requiresCOALESCEto have at least 2 arguments), but we can detect and only wrap columns inCOALESCEwhen there are multiple CTEs.filter_dimensionsto track dimensions referenced only in where clauses. These dimensions are joined for filter resolution but excluded from output projection. Filters referencing filter-only dimensions are applied in grain group CTEs only (not in final SELECT).Test Plan
Updated expected SQL in tests to remove single-argument
COALESCE+ added TestFilterOnlyDimensions test class for filter-only dimension behavior.make checkpassesmake testshows 100% unit test coverageDeployment Plan