Fix slow /downstreams endpoint for high-fanout nodes#1721
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Jan 27, 2026
Merged
Fix slow /downstreams endpoint for high-fanout nodes#1721shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/downstreamsendpoint was slow when querying nodes with many direct children. This is because for high fanout nodes, we're switching from the recursive CTE approach to BFS. The BFS path was a lot slower than the recursive CTE because it performs N queries per level, whereas the recursive CTE does traversal + eager loading in a single database query.This PR raises
fanout_thresholdfrom 50 to 10000 so that the recursive CTE is used for virtually all cases. The BFS fallback is now only triggered for extremely large graphs.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan