Fix issue when a query uses a CTE with a table alias and DJ fails to …#1723
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Jan 28, 2026
Merged
Fix issue when a query uses a CTE with a table alias and DJ fails to …#1723shangyian merged 1 commit intoDataJunction:mainfrom
shangyian merged 1 commit intoDataJunction:mainfrom
Conversation
…resolve column types. This is because when inlining a CTE as a subquery, the table alias from the FROM clause was not preserved. The CTE was inlined with its original name instead of the alias, causing column references to fail resolution.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue when a query uses a CTE with a table alias and DJ fails to resolve column types:
results in
This is because when inlining a CTE as a subquery, the table alias from the
FROMclause is not preserved. The CTE is inlined with its original name (monthly_totals) instead of the alias (m), causing column references likem.regionto fail resolution.The fix is to modify
bake_ctes()to preserve the table alias when swapping a CTE reference.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan