Fix issue where a detached relationship on RoleAssignment#1841
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Mar 8, 2026
Merged
Fix issue where a detached relationship on RoleAssignment#1841shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
…arate sessions being used to load the auth context and bearer session) was causing errors
2a4b531 to
58c82f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug:
DJHTTPBearerandget_auth_contexteach get their own database session viaDepends(get_session). The User is loaded withselectinload(role_assignments)in the bearer's session (S1), stored inrequest.state.user, then S1 closes, which expunges all its ORM objects, clearing the eagerly-loaded collection from the instance's state. Whenget_auth_contextruns in session S2 and callslist(user.role_assignments), the User is detached and the collection is gone, triggering the lazy load error.The fix is for
get_effective_assignmentsto issue a fresh select forRoleAssignmentfiltered by user id using the current session. It never touches the detached relationship at all.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan