Set upper bound for dj.data polling and fix intermittent no data errors#1857
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Mar 12, 2026
Merged
Set upper bound for dj.data polling and fix intermittent no data errors#1857shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Add retry to get final set of data after successful polling
shangyian
force-pushed
the
client-retry-data
branch
from
5661608 to
c6ac116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The client was using unbounded exponential backoff when polling for query results (1s to 2s to 4s to ... to 128s+), causing it to appear hung even after the underlying job had finished. The polling interval is now capped at 10 seconds.
Additionally, as a client-side fallback, when a FINISHED response has no results, the client now re-polls up to 3 times (with 1s/2s/4s delays) before raising the exception.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan