Fix default dialect selection: prefer Druid for cubes, Trino otherwise#1919
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Mar 25, 2026
Merged
Fix default dialect selection: prefer Druid for cubes, Trino otherwise#1919shangyian merged 3 commits intoDataJunction:mainfrom
shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
… explicitly specified
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
shangyian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/data/and/sql/metrics/v3were always generating Spark SQL when no dialect was specified, even on catalogs with a Trino engine, because resolve_dialect_and_engine_for_metrics picked engines[0] without preference and Spark happened to be first.The fix applies the intended preference end-to-end: materialized cube = Druid engine; no cube = Trino engine (falling back to first engine if no Trino engine exists on the catalog). Explicit dialect=spark = Spark as before.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan