Add a cube parameter to the python client plan API.#1983
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
jlhester
force-pushed
the
1964-dj-cube-plan-param
branch
from
ad01054 to
74d436c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass through a
cubeparameter for the DJ python clientplanAPI. The cube's filters will be prepended to the planned SQL.Test Plan
Updated unit tests, plus tested locally with the client updates on a cube with filters.
make checkpassesmake testshows 100% unit test coverageDeployment Plan