Filter pushdown should work with multi-ref filters#2021
Merged
shangyian merged 4 commits intoDataJunction:mainfrom Apr 19, 2026
Merged
Filter pushdown should work with multi-ref filters#2021shangyian merged 4 commits intoDataJunction:mainfrom
shangyian merged 4 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the earlier alias/substring fixes. Three correctness changes plus one refactor:
a.x = 1 OR b.y = 2now rewrite every matching dim ref instead of stopping after the first. If any ref resolves to a column the target CTE doesn't expose, the whole filter stays on the outer query rather than pushing a partial rewrite with an unresolved name behind.UNION/INTERSECT/EXCEPThave per-arm projections that can differ, and_inject_filter_into_whereonly mutates the first arm's WHERE. Pushing would under-filter the other arms.status = 'X') with a clear error directing the user to the fully-qualified form (v3.order_details.status = 'X'). Before, bare refs were silently routed to whichever parent node happened to expose a matching column, which is ambiguous in multi-parent builds.The rewriter itself moved from regex substitution to a two-pass AST walk that swaps
SubscriptandColumnnodes, then serializes once.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan