Skip to content

Add support for python 3.12#2025

Merged
shangyian merged 1 commit intoDataJunction:mainfrom
shangyian:py312
Apr 19, 2026
Merged

Add support for python 3.12#2025
shangyian merged 1 commit intoDataJunction:mainfrom
shangyian:py312

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

@shangyian shangyian commented Apr 19, 2026

Summary

Widens supported python versions to >=3.10,<3.13 and adds 3.12 to the CI matrix. datajunction-server now installs and tests cleanly on 3.10–3.12. Changes needed include:

  • Regenerated uv.lock and the only dependency version that moves is duckdb (0.8.1 to 1.5.2).
  • Fix order-dependent test assertions in cubes_test.py, sql_test.py, and sql_v2_test.py. Several tests compared fetchall() results against hardcoded lists without ORDER BY, implicitly depending on duckdb 0.8's hash order, which changed in 1.x.
  • Replace asyncio.get_event_loop() with asyncio.get_running_loop()

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 19, 2026

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit d044892
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/69e55f0645829700086e9007

@shangyian shangyian force-pushed the py312 branch 2 times, most recently from 73dcdda to 9178ad1 Compare April 19, 2026 09:46
@shangyian shangyian marked this pull request as ready for review April 19, 2026 23:29
@shangyian shangyian changed the title Upgrade to support python 3.12 Add support for python 3.12 Apr 19, 2026
@shangyian shangyian merged commit a02713e into DataJunction:main Apr 19, 2026
21 checks passed
@shangyian shangyian deleted the py312 branch April 19, 2026 23:30
@shangyian shangyian mentioned this pull request Apr 20, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant