Fix deployment idempotency for dimension links and downstream validation#2032
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Apr 20, 2026
Merged
Fix deployment idempotency for dimension links and downstream validation#2032shangyian merged 1 commit intoDataJunction:mainfrom
shangyian merged 1 commit intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dimension Link Reshuffling
When a node has multiple links to the same dimension with no role (e.g., two date links with different
join_on), the matching logic used (dimension name, role) as the identity key. This caused it to treat distinct links as duplicates (deleting one and updating the other) on every push, which triggered downstream revalidation.After
session.flush()inbulk_deploy_nodes_in_level, SQLAlchemy expired the dimension links collection on new revisions. Later access in_deploy_linkstriggered a lazy load that silently failed in async context, causing the match to find 0 existing links and create duplicates.Impact Propagation
Freshly deployed nodes had raw string column types (e.g.,
'bigint') that hadn't round-tripped through ColumnTypeDecorator. When impact propagation passed these tovalidate_node_query, it would fail because it expected parsedColumnTypeobjects.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan