Skip to content

Fix detached-instance crash on GraphQL dimensionLinks.foreignKeys #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shangyian merged 4 commits into from
Apr 20, 2026
Merged

Fix detached-instance crash on GraphQL dimensionLinks.foreignKeys #2034

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbd625d
The per resolver session pattern means that we need to return strawbe…
shangyian Apr 20, 2026
85f54d3
Fix
shangyian Apr 20, 2026
63542f5
Simplify
shangyian Apr 20, 2026
05b76de
Clean up
shangyian Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datajunction-server/datajunction_server/api/graphql/scalars/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import strawberry
from strawberry.scalars import JSON
from strawberry.types import Info
from sqlalchemy.orm.attributes import InstrumentedAttribute
from sqlalchemy.orm.attributes import InstrumentedAttribute, set_committed_value

from datajunction_server.api.graphql.scalars import BigInt
from datajunction_server.api.graphql.scalars.availabilitystate import (
Expand Down Expand Up @@ -222,6 +222,9 @@ def dimension_links(self) -> list[DimensionLink]:
"""
Returns the dimension links for this node revision.
"""
# Pre-seed each link's node rev to short-circuit the lazy load.
for link in self.dimension_links:
set_committed_value(link, "node_revision", self)
return [
link
for link in self.dimension_links
Expand Down
Loading