Skip to content

Fix dryrun namespace derivation to match push behavior#2038

Merged
shangyian merged 3 commits intoDataJunction:mainfrom
shangyian:branch-derivation-dryrun
Apr 21, 2026
Merged

Fix dryrun namespace derivation to match push behavior#2038
shangyian merged 3 commits intoDataJunction:mainfrom
shangyian:branch-derivation-dryrun

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

@shangyian shangyian commented Apr 21, 2026

Summary

dj push --dryrun without --namespace flag used the top-level namespace from dj.yaml instead of deriving the branch-qualified namespace (e.g., xyz.main). This caused the server to process the wrong namespace, leading to hangs or incorrect impact analysis.

The fix applies the same namespace derivation logic that push already uses.

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2026

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit faaaa88
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/69e735d145f59c0008e16cb3

@shangyian shangyian changed the title Infer dry-run namespace Fix dryrun namespace derivation to match push behavior Apr 21, 2026
@shangyian shangyian marked this pull request as ready for review April 21, 2026 08:51
@shangyian shangyian merged commit d731441 into DataJunction:main Apr 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant