Fix cube crash when requesting columns#2041
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Apr 21, 2026
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Querying a cube for both
columns { displayName }andcubeMetrics { name }(orcubeDimensions { name }) crashed with'_RawColumn' object has no attribute 'display_name':This is because the name-only cube fast path replaces
current.columnswith lightweight_RawColumnstand-ins to skip ORM hydration, but the predicate that gated the optimization only looked at the cube subfields, so a query that also requested full columns data still took the fast path and overwrote the real columns with the bare stand-ins.The predicate now also check for
columns/primaryKeyat the same selection level, so the fast path is skipped whenever the client needs the real column data.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan