Check for NodeRevision in ast cache before pulling attributes#2048
Merged
Check for NodeRevision in ast cache before pulling attributes#2048
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
jlhester
force-pushed
the
2047-noderevision-object-has-no-attribute-current
branch
from
e334f84 to
41fba2e
Compare
jlhester
force-pushed
the
2047-noderevision-object-has-no-attribute-current
branch
from
41fba2e to
a8d1746
Compare
shangyian
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some metrics using old style SQL generation will hit an edge case where a NodeRevision is added to the dj AST cache rather than a Node object. This change checks for either object type in the cache.
Test Plan
Updated unit tests and verified the error was fixed in a local instance of the DJ server
make checkpassesmake testshows 100% unit test coverageDeployment Plan