Client functionality for availability + column attributes#609
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Jul 6, 2023
Merged
Client functionality for availability + column attributes#609shangyian merged 3 commits intoDataJunction:mainfrom
shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
shangyian
changed the title
samredai
approved these changes
Jul 6, 2023
Contributor
samredai
left a comment
samredai
left a comment
There was a problem hiding this comment.
LGTM. It might be worth adding a call to each of these two methods somewhere in the integration test. 🚀
Collaborator
Author
|
@samredai Good point, added! |
youngman-droid
pushed a commit
to youngman-droid/dj
that referenced
this pull request
Aug 26, 2023
…y-attributes Client functionality for availability + column attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add client functionality to set availability state and column attributes on a node.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan