Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
squash-alembic
branch
3 times, most recently
from
2bcf0a7 to
e6c3376
Compare
youngman-droid
pushed a commit
to youngman-droid/dj
that referenced
this pull request
Aug 26, 2023
squash alembic migrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR squashes the database migrations into a single migration and updates
dj.demo.dbwith the changes.The main reason behind doing this now is that our existing migrations don't work for CockroachDB, which doesn't allow us to alter the primary key of a table in the same transaction as making another change to the table. This is allowed for sqlite, which is why the migrations were working fine with our demo docker compose setup.
Test Plan
Ran locally with the updated
dj.demo.db+ tests.make checkpassesmake testshows 100% unit test coverageDeployment Plan
We should think about how database migration maintenance should work long-term, but that's a separate discussion.